Comments on: First bounty claimed, multi-thread VIS bug fixed

http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/ The greatest Quake 1 Singleplayer site on this planet. Tue, 09 Aug 2011 22:15:18 +0000 hourly 1 By: s_a_j_t http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2257 s_a_j_t Mon, 18 Jan 2010 12:12:47 +0000 http://www.quaddicted.com/?p=1078#comment-2257 ijed: Exporter of what? By: Baker http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2256 Baker Mon, 18 Jan 2010 01:32:18 +0000 http://www.quaddicted.com/?p=1078#comment-2256 Nice! By: ijed http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2255 ijed Sun, 17 Jan 2010 21:07:20 +0000 http://www.quaddicted.com/?p=1078#comment-2255 Thanks for this. About other bounties - can we can contribute as well? I'd give my eye teeth for a proper exporter. By: Tuna http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2253 Tuna Sun, 17 Jan 2010 20:41:21 +0000 http://www.quaddicted.com/?p=1078#comment-2253 I have updated my test version: http://user.cs.tu-berlin.de/~tuna/WVis_thread_test.zip It should now use all cores no matter what. I could not trigger the "portal not done" error with this one either. If someone can confirm this version should be much nicer. (patch included) Also this version should ensure that if you hit ctrl-c while the save file is being written your save file will not be corrupted. By: Tuna http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2252 Tuna Sun, 17 Jan 2010 19:06:29 +0000 http://www.quaddicted.com/?p=1078#comment-2252 Yeah. The first priority for me was to fix the corruption of the save file. Its probably not optimal performance wise. It should still be faster than single threaded. In a case of a 16 days portal.. well yeah thats bad.. I have another build over here that should reset all portals that are being processed before writing the save file. However I had no time to actually test it yet.. By: negke http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2251 negke Sun, 17 Jan 2010 18:23:49 +0000 http://www.quaddicted.com/?p=1078#comment-2251 This seens like a somewhat counterproductive method? For if a portal on one thread takes considerably longer than all others (and by that I mean hours or more - for example in my latest map, vis got stuck on a particularly stubborn portal for 16 days), the purpose of multithreading is kind of foiled and potential processing time wasted. I thought the solution would be to make vis reset all unfinished portals when saving the state file in a way that allows vis to restart the calculation from scratch upon resume. ...Hmm, now that I think about it, this might very well have been the problem with the old version to some extend. If the vis process indeed relies on a certain order/succession in which the portals are (or have to be) processed. That's what BJP mentioned in his interpretation afaik, isn't it? By: Tuna http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2249 Tuna Sun, 17 Jan 2010 16:25:31 +0000 http://www.quaddicted.com/?p=1078#comment-2249 This was great fun! I hope this one turns out to be error free. If not let me know. Save points can cause to situations where threads will be idle while waiting to the last one to finish. I suggest increasing the save time to a higher value than the default to reduce those situations. By: Spirit http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2248 Spirit Sun, 17 Jan 2010 16:11:04 +0000 http://www.quaddicted.com/?p=1078#comment-2248 Thanks. :) By: Willem http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/comment-page-1/#comment-2247 Willem Sun, 17 Jan 2010 13:34:42 +0000 http://www.quaddicted.com/?p=1078#comment-2247 AWESOME! Seriously go ahead and make a proper release and put it on Quaketastic. Up the version number and throw a readme into that directory or something. I'm really doubting i'll have time to package this up properly anytime soon.